keyboard: Fix widget leak

We currently create an extended-keys popup every time it is requested,
but only destroy it (or rather: the last one) when the keyboard itself
is destroyed.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1976

diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js
index a0483cc8a74038050f949ebc3c7db55eabb2020a..0d40c835720cd74997ea399c58c227903c503435 100644 (file)
--- a/js/ui/keyboard.js
+++ b/js/ui/keyboard.js
@@ -292,6 +292,9 @@ var Key = GObject.registerClass({
         if (this._extendedKeys.length === 0)
             return;
 
+        if (this._boxPointer)
+            return;
+
         this._boxPointer = new BoxPointer.BoxPointer(St.Side.BOTTOM);
         this._boxPointer.hide();
         Main.layoutManager.addTopChrome(this._boxPointer);